Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change colour parsing in plot_1d_model #394

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Conversation

MBartkowiakSTFC
Copy link
Collaborator

Description of work
Changes the translation between the matplotlib and Qt colour scheme.

closes #391

Fixes
Changed the sequence of colour formats used by the plotter code.

To test

  1. Load an MDA file into the plotter.
  2. Plot a 1D curve.
  3. Right-click the plot and pick "Lines settings".
  4. Change the colour of the curve.
    All this should complete without the GUI crashing.

Copy link
Collaborator

@ChiCheng45 ChiCheng45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ChiCheng45 ChiCheng45 merged commit 5f7adc1 into protos Mar 26, 2024
84 checks passed
@MBartkowiakSTFC MBartkowiakSTFC deleted the fix-plotting-crash branch July 9, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] GUI crash in plotter window on "Lines settings"
2 participants